fix(layers): work around Samsung shader compilation failure (#8843)

visgl · Apr 26, 2024 · 827161b · 827161b
1 parent 692ae67
commit 827161b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/modules/layers/src/column-layer/column-layer-fragment.glsl.ts b/modules/layers/src/column-layer/column-layer-fragment.glsl.ts
@@ -36,6 +36,8 @@ in vec4 position_commonspace;
 
 void main(void) {
   fragColor = vColor;
+  // Fails to compile on some Android devices if geometry is never assigned (#8411)
+  geometry.uv = vec2(0.);
 #ifdef FLAT_SHADING
   if (extruded && !isStroke && !bool(picking.isActive)) {
     vec3 normal = normalize(cross(dFdx(position_commonspace.xyz), dFdy(position_commonspace.xyz)));

diff --git a/modules/layers/src/solid-polygon-layer/solid-polygon-layer-fragment.glsl.ts b/modules/layers/src/solid-polygon-layer/solid-polygon-layer-fragment.glsl.ts
@@ -30,6 +30,8 @@ out vec4 fragColor;
 
 void main(void) {
   fragColor = vColor;
+  // Fails to compile on some Android devices if geometry is never assigned (#8411)
+  geometry.uv = vec2(0.);
 
   DECKGL_FILTER_COLOR(fragColor, geometry);
 }