Allow specifying an alternate method of getting a raw body #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used if the raw body is located elsewhere in the conn. In our situation we already are pattern matching on the path in the Phoenix endpoint module with the util added in the test which came from the [Bytepack archive](https://github.com/dashbitco/bytepack_archive/blob/main/apps/bytepack_web/lib/bytepack_web/extensions/plug/body_reader.ex), so this felt much cleaner to support in the plug than define another alternate route that stores raw bodies slightly different.
moroz
approved these changes
Apr 25, 2024
Co-authored-by: Karol Moroz <k.j.moroz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used if the raw body is located elsewhere in the conn.
In our situation we already are pattern matching on the path in the Phoenix endpoint module with the util added in the test which came from the Bytepack archive, so this felt much cleaner to support in the plug than define another alternate route that stores raw bodies slightly different.
No worries if this doesn't interest you all, I'm using it on my project from my fork!