Fix pod metadata overwritten caused by updateStatus #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clarklee92 <clarklee1992@hotmail.com>
clarklee92
force-pushed
the
patch-pod-status
branch
from
156e0c3
to
2328a44
Compare
|
Re-test may be required, testing log indicates that the test node connection has timed out. I tested the UT locally and verified it in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most of the types(like pod) defined early on in Kubernetes, changes to metadata were allowed via function
UpdateStatus. https://github.com/kubernetes/kubernetes/issues/92022The way to update pod status in VK happens to be updateStatus, which may cause the change to metadata like
LabelsorAnnotationsoverwritten back to the old values(This is not inevitable, because the default interval of heartbeat reporting is 5 seconds, and the metadata of pod may be collected after modification).Signed-off-by: clarklee92 clarklee1992@hotmail.com