Add logging to help debug queueing problems #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds *logs* for information about which queue is being used / invoked. Previously this information was in traces. Signed-off-by: Sargun Dhillon <sargun@sargun.me>
cpuguy83
reviewed
Apr 16, 2021
| @@ -376,6 +377,7 @@ func (q *Queue) handleQueueItem(ctx context.Context) bool { | |||
| // We do this as the delayed nature of the work Queue means the items in the informer cache may actually be more u | |||
| // to date that when the item was initially put onto the workqueue. | |||
| ctx = span.WithField(ctx, "key", qi.key) | |||
| ctx = log.WithLogger(ctx, log.G(ctx).WithField("key", qi.key)) | |||
There was a problem hiding this comment.
Shouldn't the logger already have this key? If not that seems like a bug in the span implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logs for information about which queue is
being used / invoked. Previously this information was
in traces.
Signed-off-by: Sargun Dhillon sargun@sargun.me