Import moment locales to prevent Android crashes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert to typescript
change interface name
add swiping and update readme
|
@vinodkumar8 please check this out. Thanks! |
|
Is that only change required? |
|
Yes. I got a working solution from moment/moment#3624 The only real change was to import the all of the locales from moment. Sorry for this long list of commits. It looks like it pulled all of my commits from when I first forked this. It added all of them when I rebased with this master branch. |
|
@vinodkumar8 would you like me to make any changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android production builds will crash if you try to pass a moment locale to the component without importing the locales from moment first.