Fetch a fresh quote each time getQuote() is called #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch a new quote every time getQuote() is called, without needing to require() the package again.
|
Thanks for opening this pull request! 🤗 📢 Spread the word about @vinitshahdeo/Hacktoberfest2021 repo across your social media channels to help get others involved! Give a shoutout to our initiative. Retweet this. Check out few other repos below 🚀
Show some ❤️
Say Hi on Twitter! 👋PS: Please add @vinitshahdeo as a reviewer if you haven't added. |
|
this repo is dead @ribcatcher give up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if I run getQuote() multiple times, it returns the same quote again and again.
This fixes that and returns a fresh quote every time getQuote() is run.
I think this is simple enough, passes all tests.