Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wiki page #148

Open
wants to merge 1 commit into
base: feature/wiki-docs
Choose a base branch
from

Conversation

minolipvartak
Copy link

Description

In the previous PR, the wiki page, located inside a submodule, was not visible after being merged.

Fixes # (issue)

Type of change

Took wiki page outside of a submodule so that it can be viewed

  • This change requires a documentation update

Reviewer: Vinit Shahdeo

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wiki is not a copy of your readme. Please add more about the project and show your creativity.

@minolipvartak
Copy link
Author

minolipvartak commented Mar 10, 2020 via email

@PragatiVerma18
Copy link
Contributor

Any updates @minolipvartak? It's been 23 days already. I may have to close this PR if it remains inactive the same way for any longer. Also, this PR should be made to feature/documentation branch and not to a new branch.

@minolipvartak
Copy link
Author

Any updates @minolipvartak? It's been 23 days already. I may have to close this PR if it remains inactive the same way for any longer. Also, this PR should be made to feature/documentation branch and not to a new branch.

Hello @PragatiVerma18 I have pinged you on Slack regarding this issue few days ago. Can you please check it and clear those doubts?

@PragatiVerma18
Copy link
Contributor

Any updates @minolipvartak? It's been 23 days already. I may have to close this PR if it remains inactive the same way for any longer. Also, this PR should be made to feature/documentation branch and not to a new branch.

Hello @PragatiVerma18 I have pinged you on Slack regarding this issue few days ago. Can you please check it and clear those doubts?

@minolipvartak Please ask your doubts right here and be active on your PR.

@minolipvartak
Copy link
Author

minolipvartak commented Apr 14, 2020 via email

Copy link
Contributor

@harshita19244 harshita19244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki page can get rid of re-iterative content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants