New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: add PicoLisp filetype #14476
Draft
nat-418
wants to merge
5
commits into
vim:master
Choose a base branch
from
nat-418:runtime-add-picolisp
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkearns
requested changes
Apr 10, 2024
nat-418
force-pushed
the
runtime-add-picolisp
branch
from
April 10, 2024 14:42
a9f88b7
to
64034de
Compare
zeertzjq
reviewed
Apr 10, 2024
zeertzjq
reviewed
Apr 10, 2024
nat-418
force-pushed
the
runtime-add-picolisp
branch
3 times, most recently
from
April 10, 2024 15:32
89906bf
to
3901a62
Compare
nat-418
force-pushed
the
runtime-add-picolisp
branch
from
April 10, 2024 15:32
3901a62
to
67320b1
Compare
dkearns
requested changes
Apr 10, 2024
Co-authored-by: dkearns <dougkearns@gmail.com>
Co-authored-by: dkearns <dougkearns@gmail.com>
thanks, but tests still seem to fail. |
nat-418
force-pushed
the
runtime-add-picolisp
branch
3 times, most recently
from
April 10, 2024 22:53
1ceb2df
to
c128fe7
Compare
test still fails :/ Let me convert to draft and let me know once this is ready. |
nat-418
force-pushed
the
runtime-add-picolisp
branch
3 times, most recently
from
April 13, 2024 20:34
e177f08
to
40c0458
Compare
nat-418
force-pushed
the
runtime-add-picolisp
branch
from
April 13, 2024 22:15
40c0458
to
9e77dd8
Compare
zeertzjq
reviewed
Apr 13, 2024
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
zeertzjq
reviewed
Apr 14, 2024
exe "setf " .. g:filetype_l | ||
return | ||
endif | ||
for i in range(1, line("$")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many filetype detection functions have a limit to the number of lines to check, like using range(1, min([line("$"), 100]))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the PicoLisp programming language.
PicoLisp exclusively uses the*.l
filename extension, which is currently also used by Lex among several other extensions, so I have removed*.l
from the Lex filename extensions and transferred it to PicoLisp.