feat: able to change the ordering of popup menu #14006
Conversation
|
thanks, that sounds interesting. However I think the option value should not be an opaque integer value Hopefully that is flexible enough and others don't want printf() formatting strings (or add arbitrary items to the pum menu). |
chrisbra
added
the
needs more work
|
I see that some of the computation can be done at the option set callback, do I need to move the computation to the callback? |
|
I don't think so. The option callback is for completing option values. Does that work? |
|
can you please fix the failing CI? |
|
I might need to add some tests too. |
|
yes, please add tests |
runtime/doc/options.txt
Outdated
| @@ -6273,6 +6273,23 @@ A jump table for the options with a short description can be found at |Q_op|. | |||
| Insert mode completion. When zero as much space as available is used. | |||
| |ins-completion-menu|. | |||
|
|
|||
| *'pumordering'* *'po'* | |||
| 'pumordering' 'po' string (default "012") | |||
There was a problem hiding this comment.
this should be "word,kind,extra" ?
runtime/doc/options.txt
Outdated
| The default value: | ||
| 0: word | ||
| 1: kind | ||
| 2: extra |
There was a problem hiding this comment.
same here, default value is no longer 0,1,2
src/popupmenu.c
Outdated
| for (r = 0; r < 3; ++r) | ||
| { | ||
| if (rounds[r] == 0 && prefix_pum_widths[rounds[r]] > 0) | ||
| { |
There was a problem hiding this comment.
please remove braces around single-line statements
|
can you add a few tests for:
|
|
I would say the current behavior for this case I could make it so that |
| let buf = RunVimInTerminal('-S Xscript', {}) | ||
| call TermWait(buf) | ||
| call term_sendkeys(buf, "iaw\<C-X>\<C-u>") | ||
| call TermWait(buf, 50) |
There was a problem hiding this comment.
TermWait() is not needed before VerifyScreenDump()
runtime/doc/options.txt
Outdated
| So the popup menu should look like the following | ||
| "word" "kind" "extra" | ||
|
|
||
| If this value is set to 102, the popup menu would look like this: |
What do you mean with it?
So that would basically mean, we would be able to re-order items, but cannot leave out items, right? |
|
If user do this |
Yes, it might be weird, and it sounds like a "don't complain if you use this setting and Vim does what you tell it. Don't do it then". Not sure if this should be allowed to have only 'extra' in 'pumordering'. Opinions? |
hi.
I was wondering if we can have a feature to change the ordering of the popup menu. The current popup menu is ordered as "word", "kind", "extra". I'm using an option to control this for now, not sure if there's a better way to accomplish this.
vim.mp4