Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime(html): Fix syntax test failures #13595

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dkearns
Copy link
Contributor

@dkearns dkearns commented Nov 29, 2023

Problem: htmlItalic highlight group dump file differences on macOS are
causing test failures.
Solution: Remove content from <em> and <i> element examples in the HTML
test file.

The included content for these elements was incidental to the primary
intent of the test to check element tag highlighting. See #13591.

@dkearns dkearns marked this pull request as draft November 29, 2023 14:20
@dkearns dkearns force-pushed the runtime-html-fix-macos-test-failure branch 2 times, most recently from afa90ac to 1492cce Compare November 29, 2023 14:55
Problem:  htmlItalic highlight group dump file differences on macOS are
          causing test failures.
Solution: Remove content from <em> and <i> element examples in the HTML
          test file.

The included content for these elements was incidental to the primary
intent of the test to check element tag highlighting. See vim#13591.
@dkearns dkearns force-pushed the runtime-html-fix-macos-test-failure branch from 1492cce to c55994c Compare November 30, 2023 10:23
@dkearns
Copy link
Contributor Author

dkearns commented Nov 30, 2023

It seems that even an empty <strike></strike> element breaks the HTML syntax test on FreeBSD but not macOS.

testdir/failed/html_08.dump is the reported failure. I can't see a specific dump file line reported but commenting out the strike element, which also uses a custom strikethrough highlight group, results in a passing test.

I don't have any experience with screen dumps. Are they usually reliable across platforms?

@chrisbra
Copy link
Member

I don't know, but perhaps the FreeBSD CI does not support the strikethrough attribute? I don't think we have tested that one before in a screen-dump test. Perhaps we should leave that one out (or skip the test on BSD and Mac) in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants