Skip to content

Commit

Permalink
patch 8.2.3580: gj does not move properly with a wide character
Browse files Browse the repository at this point in the history
Problem:    gj does not move properly with a wide character.
Solution:   Move one to the right. (Christian Brabandt, closes #8702)
  • Loading branch information
chrisbra authored and brammool committed Nov 4, 2021
1 parent 4b2c804 commit aaec1d4
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/normal.c
Expand Up @@ -2530,7 +2530,7 @@ nv_screengo(oparg_T *oap, int dir, long dist)
int col_off1; // margin offset for first screen line
int col_off2; // margin offset for wrapped screen line
int width1; // text width for first screen line
int width2; // test width for wrapped screen line
int width2; // text width for wrapped screen line

oap->motion_type = MCHAR;
oap->inclusive = (curwin->w_curswant == MAXCOL);
Expand Down Expand Up @@ -2656,6 +2656,7 @@ nv_screengo(oparg_T *oap, int dir, long dist)
if (curwin->w_cursor.col > 0 && curwin->w_p_wrap)
{
colnr_T virtcol;
int c;

/*
* Check for landing on a character that got split at the end of the
Expand All @@ -2669,6 +2670,12 @@ nv_screengo(oparg_T *oap, int dir, long dist)
virtcol -= vim_strsize(get_showbreak_value(curwin));
#endif

c = (*mb_ptr2char)(ml_get_cursor());
if (dir == FORWARD && virtcol < curwin->w_curswant
&& (curwin->w_curswant <= (colnr_T)width1)
&& !vim_isprintc(c) && c > 255)
oneright();

if (virtcol > curwin->w_curswant
&& (curwin->w_curswant < (colnr_T)width1
? (curwin->w_curswant > (colnr_T)width1 / 2)
Expand Down
12 changes: 12 additions & 0 deletions src/testdir/test_normal.vim
Expand Up @@ -3423,4 +3423,16 @@ func Test_normal_count_after_operator()
bw!
endfunc

func Test_normal_gj_on_extra_wide_char()
new | 25vsp
let text='1 foooooooo ar e ins‍zwe1 foooooooo ins‍zwei' .
\ ' i drei vier fünf sechs sieben acht un zehn elf zwöfl' .
\ ' dreizehn v ierzehn fünfzehn'
put =text
call cursor(2,1)
norm! gj
call assert_equal([0,2,25,0], getpos('.'))
bw!
endfunc

" vim: shiftwidth=2 sts=2 expandtab
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -757,6 +757,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
3580,
/**/
3579,
/**/
Expand Down

0 comments on commit aaec1d4

Please sign in to comment.