Skip to content

Commit

Permalink
patch 9.0.0219: cannot make a funcref with "s:func" in a def function
Browse files Browse the repository at this point in the history
Problem:    Cannot make a funcref with "s:func" in a def function in legacy
            script.
Solution:   Allow for using a lower case function name after "s:". (Kota Kato,
            closes #10926)
  • Loading branch information
kat0h authored and brammool committed Aug 16, 2022
1 parent e98c88c commit 948a389
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 4 deletions.
39 changes: 39 additions & 0 deletions src/testdir/test_vim9_func.vim
Expand Up @@ -1957,6 +1957,45 @@ def Test_call_funcref()
g:listarg->assert_equal([1, 2, 3])
END
v9.CheckScriptSuccess(lines)

lines =<< trim END
function s:func(num)
return a:num * 2
endfunction

def s:CallFuncref()
var Funcref = function('s:func')
Funcref(3)->assert_equal(6)
enddef
call s:CallFuncref()
END
v9.CheckScriptSuccess(lines)

lines =<< trim END
function s:func(num)
return a:num * 2
endfunction

def s:CallFuncref()
var Funcref = function(s:func)
Funcref(3)->assert_equal(6)
enddef
call s:CallFuncref()
END
v9.CheckScriptSuccess(lines)

lines =<< trim END
function s:func(num)
return a:num * 2
endfunction

def s:CallFuncref()
var Funcref = s:func
Funcref(3)->assert_equal(6)
enddef
call s:CallFuncref()
END
v9.CheckScriptSuccess(lines)
enddef

let SomeFunc = function('len')
Expand Down
3 changes: 2 additions & 1 deletion src/userfunc.c
Expand Up @@ -3995,7 +3995,8 @@ trans_function_name(
{
if (!vim9_local)
{
if (vim9script && lead == 2 && !ASCII_ISUPPER(*lv.ll_name))
if (vim9script && lead == 2 && !ASCII_ISUPPER(*lv.ll_name)
&& current_script_is_vim9())
{
semsg(_(e_function_name_must_start_with_capital_str), start);
goto theend;
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -735,6 +735,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
219,
/**/
218,
/**/
Expand Down
5 changes: 2 additions & 3 deletions src/vim9expr.c
Expand Up @@ -8,7 +8,7 @@
*/

/*
* vim9cmds.c: Dealing with compiled function expressions
* vim9expr.c: Dealing with compiled function expressions
*/

#define USING_FLOAT_STUFF
Expand Down Expand Up @@ -451,8 +451,7 @@ compile_load(
vim_free(name);
return FAIL;
}
if (is_expr && ASCII_ISUPPER(*name)
&& find_func(name, FALSE) != NULL)
if (is_expr && find_func(name, FALSE) != NULL)
res = generate_funcref(cctx, name, FALSE);
else
res = compile_load_scriptvar(cctx, name,
Expand Down

0 comments on commit 948a389

Please sign in to comment.