Update/New userfunc.{txt,jax} #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuyoshicho
requested review from
h-east and
k-takata
and removed request for
h-east and
k-takata
tsuyoshicho
force-pushed
the
update/20221009/userfunc
branch
3 times, most recently
from
5b0be82
to
4ec5669
Compare
Merged
|
切り出した部分と、今回新規に翻訳した部分が分かれていればレビューしやすかったのですが。 |
|
あー、コミット的に混ってしまっていますね...すみません。 |
k-takata
reviewed
Oct 23, 2022
doc/userfunc.jax
Outdated
Comment on lines
417
to
418
| In |Vim9| script there is also an autoload mechanism for imported scripts, see | ||
| |import-autoload|. |
doc/userfunc.jax
Outdated
| :let foo#bar#toggle = 1 | ||
| :call foo#bar#func() | ||
|
|
||
| オートロードスクリプト内で定義されるはずの関数を呼んだがスクリプト内で関数が定 |
There was a problem hiding this comment.
when you make a mistake の訳が抜けています。
k-takata
reviewed
Oct 23, 2022
k-takata
reviewed
Oct 29, 2022
doc/userfunc.jax
Outdated
| 定義されるようにすることができる。これには2つの方法がある: 自動コマンドによ | ||
| る方法と、'runtimepath' 内の "autoload" ディレクトリによる方法である。 | ||
|
|
||
| In |Vim9| script there is also an autoload mechanism for imported scripts, see | ||
| |import-autoload|. | ||
| Vim9| script ではインポートすることによるスクリプトの自動読み込みメカニズムも |
There was a problem hiding this comment.
Suggested change
| Vim9| script ではインポートすることによるスクリプトの自動読み込みメカニズムも | |
| |Vim9| script ではインポートすることによるスクリプトの自動読み込みメカニズムも |
| が抜けています。
"imported scripts" はそのまま「インポートされたスクリプト」でよい気もしますが。
There was a problem hiding this comment.
ぶ、たしかにそうなので直します。
(見直したときはあった気がしたのに)
k-takata
reviewed
Oct 31, 2022
k-takata
approved these changes
Oct 31, 2022
|
前置詞 -> プリフィックスの対応もします。 |
|
@k-takata san
とのことなので、追加部分を確認いただいて、問題なければマージという方向でどうでしょうか? |
|
#1153 をマージしたのでリベースしていただけますか。 |
Co-authored-by: K.Takata <kentkt@csc.jp>
Co-authored-by: K.Takata <kentkt@csc.jp>
Co-authored-by: K.Takata <kentkt@csc.jp>
Co-authored-by: K.Takata <kentkt@csc.jp>
tsuyoshicho
force-pushed
the
update/20221009/userfunc
branch
from
6a4e39c
to
2f6a507
Compare
|
@k-takata san |
k-takata
approved these changes
Nov 11, 2022
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
翻訳(+evalからの切り出し)をしました、よろしくおねがいします。
註: evalのPR後 rebase するまでは helptag がコンフリクトする
require #1153
typo(と思うもの) vim-jp/issues#1387 (comment)