Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneliner for pathogen install #365

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DrewBarrett
Copy link

#15

var url = (this.props.github_url || "").replace(/\/$/, "");
// now get the words after last / in url (the title)
var pos = url.lastIndexOf("/") + 1;
var bundleName = url.substr(pos);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than doing this string parsing here, I think it would be preferable to pass the github_repo_name prop from Plugin through to this component.

@DrewBarrett
Copy link
Author

Screenshot:
image
The way the line wraps isn't pretty

@captbaritone
Copy link
Member

Hmm. We could add some explicit line breaks:

git clone https://github.com/long-user-name/long-package-name \
    ~/.vim/bundle/nermcommenter

But that could confuse some people and it won't work for all cases (I'm sure there are some very long plugin names that would cause even the first line to wrap).

Maybe it's best to just leave it as two commands?

@DrewBarrett
Copy link
Author

Well we already have git clone https://github.com/long-user-name/long-package-name on one line with the existing implementation. I like the explicit line break idea myself.

@captbaritone
Copy link
Member

captbaritone commented Aug 18, 2017 via email

Contains line over 80 chars
@DrewBarrett
Copy link
Author

DrewBarrett commented Aug 18, 2017

image
The only way I could get the second line to indent was to go over 80 chars which looks very out of place with the rest of the code. It copy & pastes into bash correctly .

Ok it looks like a few  's or similar should allow us to keep the indentation and keep the code pretty

@daonb
Copy link

daonb commented Jun 23, 2019

Looks like old clutter. IMO, it should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants