New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oneliner for pathogen install #365
base: master
Are you sure you want to change the base?
Conversation
web/static/js/Install.jsx
Outdated
var url = (this.props.github_url || "").replace(/\/$/, ""); | ||
// now get the words after last / in url (the title) | ||
var pos = url.lastIndexOf("/") + 1; | ||
var bundleName = url.substr(pos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than doing this string parsing here, I think it would be preferable to pass the github_repo_name
prop from Plugin
through to this component.
Hmm. We could add some explicit line breaks:
But that could confuse some people and it won't work for all cases (I'm sure there are some very long plugin names that would cause even the first line to wrap). Maybe it's best to just leave it as two commands? |
Well we already have |
Sounds good. Let me know what you come up with.
…--
Jordan Eldredge (mobile)
On Aug 14, 2017, at 9:51 PM, Drew Barrett ***@***.***> wrote:
Screenshot:
The way the line wraps isn't pretty
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contains line over 80 chars
Looks like old clutter. IMO, it should be closed. |
#15