Make map style support localization #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for junaan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 32 32
Lines 809 809
Branches 235 235
=======================================
Hits 803 803
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
0d9d943
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93c896c8.live-trains-finland.pages.dev |
| Branch Preview URL: | https://map-localization.live-trains-finland.pages.dev |
# Conflicts: # src/utils/map.ts
When changing mapStyle which occurs when switching locale, maplibre-gl occasionally throws errors related to missing layer referred to in beforeId props. Disabling styleDiffing seems to be a workaround. See related issues: * maplibre/maplibre-gl-js#2587 * visgl/react-map-gl#939 * visgl/react-map-gl#1812
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.