6 remove deprecated setuppy and replace with toml #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 6-remove-deprecated-setuppy-and-replace-with-toml
bro-wi
changed the base branch from
development
to
23-be-less-strict-with-dependencies-in-requirements
bro-wi
force-pushed
the
6-remove-deprecated-setuppy-and-replace-with-toml
branch
from
bf3b86a
to
a11d568
Compare
bro-wi
commented
Mar 20, 2024
Comment on lines
-10
to
-11
| long_description = (Path(__file__).parent / "README.md").read_text() | ||
| long_description = long_description.replace("X.Y.Z", about["__version__"]) |
There was a problem hiding this comment.
this not covered by the new pyproject.toml now. I would suggest to change it into a dynamic badge: https://img.shields.io/github/v/tag/viktor-platform/bro?sort=date
@regbers-viktor: not sure if there was another reason to do this static?
Base automatically changed from
23-be-less-strict-with-dependencies-in-requirements
to
development
March 25, 2024 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have migrated setup.py to pyproject.toml
I also made the requirements a single source of truth instead of the two registries previously.
One setting I was not sure about what it does, I haven't include that in the pyproject.toml. I really would appreciate if you could look into that:
Regards Wichard.