This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Vikpe.
First, awesome repo. It is very similar to what I have going on privately. But I wanted to add a few things that I have discovered to be a bit more flexible for CI and deploying on containers.
My edits:
npm prune --production
to remove all of the dev dependencies on builds before they perform a release. This ensures a smaller disk size needed for any deployments, which is really nice for docker containers. Unfortunately, I have not found a yarn equivalent to perform this same action.As a side note, if you accept this, I would happily do the same for your other repos listed in the README.
Feel free to add any questions 💯