Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Express as a Dependency #11

Merged
merged 3 commits into from Aug 1, 2019
Merged

Express as a Dependency #11

merged 3 commits into from Aug 1, 2019

Conversation

wagnerjt
Copy link
Contributor

Hello Vikpe.

First, awesome repo. It is very similar to what I have going on privately. But I wanted to add a few things that I have discovered to be a bit more flexible for CI and deploying on containers.

My edits:

  1. Express is now marked as a Dependency instead of a Dev Dependency.
    • Essentially this allows people to perform a npm prune --production to remove all of the dev dependencies on builds before they perform a release. This ensures a smaller disk size needed for any deployments, which is really nice for docker containers. Unfortunately, I have not found a yarn equivalent to perform this same action.
  2. Made Express listen to an optional Environment Variable set for the Port
  3. Added a bit more documentation

As a side note, if you accept this, I would happily do the same for your other repos listed in the README.

Feel free to add any questions 💯

@vikpe vikpe merged commit 63bc595 into vikpe:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants