submit #24
Open
submit #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlangton
reviewed
Mar 2, 2017
| } | ||
| } | ||
|
|
||
| var _squarePiece = function() { |
There was a problem hiding this comment.
It looks like there's a bunch of duplication between the _piece functions. You might be able to pull out the data that defines the shape of each piece into a simple data structure, and then pass those settings into a more generic _piece function.
One tactic you could try for this refactoring would be to identify what changes between each function and pass those into the function as arguments.
There was a problem hiding this comment.
Overall, this looks great! I can't seem to get the rotation to work though :O What key am I supposed to press?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.