Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project_danebook #49

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

project_danebook #49

wants to merge 62 commits into from

Conversation

KenKot
Copy link

@KenKot KenKot commented Dec 10, 2016

No description provided.

@SampsonCrowley
Copy link

opening the root url ("/") while logged in does not redirect back to a signed in page or give any indication of being still logged in.

recommended to add a condition to your signup url to redirect to the user's timeline if logged in

@SampsonCrowley
Copy link

Shows current user's birthday on all pages instead of profile I'm viewing. don't overuse current user.

use @user when viewing info and current user when editing info

@SampsonCrowley
Copy link

SampsonCrowley commented Dec 10, 2016

users/1/timeline path is non-existant

clicking the timeline button in the navbar causes application failure.

make the link a dead link until you are ready to implement

recommended to use the users#index for your main timeline, and users#show as individual timelines.

then you can keep your users#profiles#show for profile pages

@SampsonCrowley
Copy link

can't make posts or comments. no path available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants