Danebook #36
Open
Danebook #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 10, 2016 11:27
| end | ||
|
|
||
| def timeline | ||
| @profile = false |
There was a problem hiding this comment.
Do these routes get used? May not need the @profile = false's any more.
There was a problem hiding this comment.
Ah they do. Perhaps you could add a before_action: set_profile_to_false at the top.
There was a problem hiding this comment.
Are you still using your static pages routes? Might want to pull them out into something RESTful if so
added 15 commits
August 12, 2016 18:25
| else | ||
| redirect_to user_posts_path(@user) | ||
| end | ||
| end |
There was a problem hiding this comment.
This method looks a bit hairy. Might be worth pulling some of it out into a model or at least putting it in a private helper in the controller. Same with the destroy method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.