Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String pid #514

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

String pid #514

wants to merge 30 commits into from
+104 −38

Conversation

undefined-moe
Copy link
Member

Rebased.

@undefined-moe undefined-moe mentioned this pull request May 13, 2019
Closed
twd2
twd2 reviewed May 13, 2019
View reviewed changes
vj4/handler/contest.py Outdated Show resolved Hide resolved
vj4/handler/contest.py Outdated Show resolved Hide resolved
vj4/handler/problem.py Outdated Show resolved Hide resolved
vj4/model/adaptor/problem.py Show resolved Hide resolved
vj4/ui/templates/components/problem.html Outdated Show resolved Hide resolved
vj4/util/validator.py Outdated Show resolved Hide resolved
twd2
twd2 reviewed May 14, 2019
View reviewed changes
Copy link
Member

@twd2 twd2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider opening a new branch and rewrite.

vj4/handler/contest.py Outdated Show resolved Hide resolved
vj4/handler/problem.py Outdated Show resolved Hide resolved
vj4/handler/problem.py Show resolved Hide resolved
vj4/handler/user.py Outdated Show resolved Hide resolved
@undefined-moe undefined-moe mentioned this pull request May 14, 2019
Open
iceboy233
iceboy233 reviewed May 14, 2019
View reviewed changes
vj4/model/document.py Outdated Show resolved Hide resolved
@undefined-moe
Copy link
Member Author

It seems that it's working properly now.

iceboy233
iceboy233 reviewed May 28, 2019
View reviewed changes
vj4/locale/zh_CN.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceboy233 iceboy233 iceboy233 left review comments

@twd2 twd2 twd2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@undefined-moe @iceboy233 @twd2