added custom action to vg-analytics #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfeinUI
reviewed
Apr 24, 2017
| @@ -140,6 +142,8 @@ angular.module("com.2fdevs.videogular.plugins.analytics", ["angulartics"]) | |||
| } | |||
| } else if (eventType === 'time') { | |||
| info.value = Math.floor(API.currentTime / 1000); | |||
| } else if (typeof(eventType) === 'object' && eventType.value) { | |||
kfeinUI
reviewed
Apr 24, 2017
| @@ -81,7 +81,7 @@ angular.module("com.2fdevs.videogular.plugins.analytics", ["angulartics"]) | |||
|
|
|||
| scope.onPlayerReady = function onPlayerReady(isReady) { | |||
| if (isReady) { | |||
| scope.trackEvent("ready"); | |||
| scope.trackEvent(scope.vgTrackInfo.events.ready.action || "ready"); | |||
There was a problem hiding this comment.
Duplication could be reduced with a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on a project where I introduced videogular. I currently setting up event tracking for the project so I decided to give a try to the vg-analytics plugin.
In my case I need to specify the action names for the events in the application. vg-analytics does not support it, this is why I'm creating this pull request.
In the code I introduced the possibility to pass a configuration object as
vgTrackInfo. There are also some new test to verify this scenario.As an example: