Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light ESM build #6307

Merged
merged 1 commit into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 19 additions & 17 deletions build-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,60 +202,62 @@ const basePlugins = [
commonjs({ transformMixedEsModules: true }),
];

function getAliasesForLightDist() {
function getAliasesForLightDist(format) {
const emptyFile = format === 'esm' ? 'empty-es.js' : 'empty.js';

let aliases = {};

if (!addEMESupport) {
aliases = {
...aliases,
'./controller/eme-controller': './empty.js',
'./utils/mediakeys-helper': './empty.js',
'../utils/mediakeys-helper': '../empty.js',
'./controller/eme-controller': `./${emptyFile}`,
'./utils/mediakeys-helper': `./${emptyFile}`,
'../utils/mediakeys-helper': `../${emptyFile}`,
};
}

if (!addCMCDSupport) {
aliases = { ...aliases, './controller/cmcd-controller': './empty.js' };
aliases = { ...aliases, './controller/cmcd-controller': `./${emptyFile}` };
}

if (!addSubtitleSupport) {
aliases = {
...aliases,
'./utils/cues': './empty.js',
'./controller/timeline-controller': './empty.js',
'./controller/subtitle-track-controller': './empty.js',
'./controller/subtitle-stream-controller': './empty.js',
'./utils/cues': `./${emptyFile}`,
'./controller/timeline-controller': `./${emptyFile}`,
'./controller/subtitle-track-controller': `./${emptyFile}`,
'./controller/subtitle-stream-controller': `./${emptyFile}`,
};
}

if (!addAltAudioSupport) {
aliases = {
...aliases,
'./controller/audio-track-controller': './empty.js',
'./controller/audio-stream-controller': './empty.js',
'./controller/audio-track-controller': `./${emptyFile}`,
'./controller/audio-stream-controller': `./${emptyFile}`,
};
}

if (!addVariableSubstitutionSupport) {
aliases = {
...aliases,
'./utils/variable-substitution': './empty.js',
'../utils/variable-substitution': '../empty.js',
'./utils/variable-substitution': `./${emptyFile}`,
'../utils/variable-substitution': `../${emptyFile}`,
};
}

if (!addM2TSAdvancedCodecSupport) {
aliases = {
...aliases,
'./ac3-demuxer': '../empty.js',
'./video/hevc-video-parser': '../empty.js',
'./ac3-demuxer': `../${emptyFile}`,
'./video/hevc-video-parser': `../${emptyFile}`,
};
}

if (!addMediaCapabilitiesSupport) {
aliases = {
...aliases,
'../utils/mediacapabilities-helper': '../empty.js',
'../utils/mediacapabilities-helper': `../${emptyFile}`,
};
}

Expand Down Expand Up @@ -300,7 +302,7 @@ const buildRollupConfig = ({
? [alias({ entries: { './transmuxer-worker': '../empty.js' } })]
: []),
...(type === BUILD_TYPE.light
? [alias({ entries: getAliasesForLightDist() })]
? [alias({ entries: getAliasesForLightDist(format) })]
: []),
...(format === 'esm'
? [buildBabelEsm({ stripConsole: true })]
Expand Down
5 changes: 5 additions & 0 deletions src/empty-es.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// This file is inserted as a shim for modules which we do not want to include into the distro.
// This replacement is done in the "alias" plugin of the rollup config.
// Use a ES dedicated file as Rollup assigns an object in the output
// For example: "var KeySystemFormats = emptyEs.KeySystemFormats;"
module.exports = {};