Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for replica set connections #2690

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gedaiu
Copy link
Contributor

@gedaiu gedaiu commented Sep 12, 2022

I just made some changes in my fork that allows me to connect to mongo replica sets. This might be useful for some other people too.

@gedaiu gedaiu changed the title Add bais support for replica set connections Add basic support for replica set connections Sep 12, 2022
Copy link
Member

@s-ludwig s-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICS. The code would just have to be rebased again and slightly adjusted to incorporate the new connection timeout setting for the connectTCP call.

@@ -746,6 +774,8 @@ struct ServerDescription
Nullable!int setVersion;
Nullable!BsonObjectID electionId;
string primary;
bool secondary;
bool ismaster;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this in the documentation, is this an undocumented field, or am I just looking in the wrong place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants