Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use current UUID type #2399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: use current UUID type #2399

wants to merge 2 commits into from

Conversation

tirithen
Copy link
Contributor

std.uuid.UUID as being converted to the legacy BSON UUID type.

BREAKING CHANGE: type change from BinData 0x03 to 0x04 for std.uuid.UUID

@s-ludwig
Copy link
Member

We'll have to go through a deprecation phase here to avoid the immediate breakage. I'd suggest to add two new definitions (uuidOld = 0x03 and uuidNew = 0x04) and then mark uuid as deprecated, but keep it as 0x03. Then, Bson.get would need to be adjusted to allow both, 0x03 and 0x04, and the remaining uses would be replaced by uuidNew.

Finally, in the next major release, uuid would then be changed to alias to uuidNew instead of uuidOld.

@tirithen
Copy link
Contributor Author

@s-ludwig I see, make sense deprecating first, I'll stay on my fork for now. It's such a nice design in that it can take the base structs and automatically map the members from and to BSON without annotations. Thanks for a nice library.

@thaven
Copy link
Contributor

thaven commented Feb 6, 2020

feat(SysTime): add support to parse SysTime 17f897b
feat: serialize SysTime b41b7ef
Merge branch 'master' of github.com:tirithen/vibe.d 4adcc91

@tirithen I suppose you did not mean to push these commits to this PR?

@tirithen
Copy link
Contributor Author

tirithen commented Feb 6, 2020 via email

std.uuid.UUID as being converted to the legacy BSON UUID type.

BREAKING CHANGE: type change from BinData 0x03 to 0x04 for std.uuid.UUID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants