Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vanilla example to use Vite + TS app for robot client #300

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

ethanlook
Copy link
Contributor

@ethanlook ethanlook commented May 17, 2024

I've been using this simple Vite + TypeScript app to test during local development and figured it's probably more broadly useful. Please let me know if you don't like this in any way, I'm happy to make changes, abandon it, etc.

teleop-vanilla

  1. Emit connectionstatechange events #299
  2. ➡️ Update vanilla example to use Vite + TS app for robot client #300

Change log

  • npm create vite@latest teleop-vanilla
  • Brief README
  • Limited connect / disconnect / log resources UI
  • Edit: moved to vanilla, no longer teleop-vanilla

@ethanlook ethanlook marked this pull request as ready for review May 17, 2024 14:03
@ethanlook ethanlook requested a review from a team as a code owner May 17, 2024 14:03
@ethanlook ethanlook requested review from njooma and purplenicole730 and removed request for a team May 17, 2024 14:03
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but I think maybe we just replace the existing "vanilla" example with this one? This seems more fully featured and actually how users would use our SDK

@ethanlook
Copy link
Contributor Author

I like this, but I think maybe we just replace the existing "vanilla" example with this one? This seems more fully featured and actually how users would use our SDK

@njooma works for me! I'll rework this to replace the "vanilla" example.

Base automatically changed from ethanlook/connectionstatechange to main May 21, 2024 20:52
@ethanlook ethanlook changed the title Add example Vite + TS app for robot client Update vanilla example to use Vite + TS app for robot client May 24, 2024
@ethanlook
Copy link
Contributor Author

Sorry for the delay here - this is ready for review again and now updates the vanilla example. I am about to be out for 2 weeks, please feel free to take this over or merge if you see fit, otherwise I will come back to it when I return!

@njooma njooma merged commit 26ceb27 into main Jun 7, 2024
3 checks passed
@njooma njooma deleted the ethanlook/teleop-vanilla branch June 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants