New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions use Google Credentials #1140
Conversation
.github/workflows/pullrequest.yml
Outdated
@@ -16,10 +16,11 @@ on: | |||
|
|||
jobs: | |||
test: | |||
uses: viamrobotics/rdk/.github/workflows/test.yml@main | |||
uses: viamrobotics/rdk/.github/workflows/test.yml@support-credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR currently contains the test code pointing test.yaml to this branch. Once tests pass on the first run i'll update PR to remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's get rid of the extra move steps
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooooo
To avoid an issue with google go sdk leaking goroutines we need to ensure it has a proper credential file which avoids it looking up metadata from the GCE metadata endpoints. See: googleapis/google-cloud-go#5430
fdd8a20
to
fab46f4
Compare
To avoid an issue with google go sdk leaking goroutines we need to ensure it has a proper credential file which avoids it looking up metadata from the GCE metadata endpoints.
Fixes: RSDK-526
See: googleapis/google-cloud-go#5430