Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions use Google Credentials #1140

Merged
merged 4 commits into from Aug 10, 2022
Merged

Github Actions use Google Credentials #1140

merged 4 commits into from Aug 10, 2022

Conversation

AdamMagaluk
Copy link
Contributor

@AdamMagaluk AdamMagaluk commented Aug 9, 2022

To avoid an issue with google go sdk leaking goroutines we need to ensure it has a proper credential file which avoids it looking up metadata from the GCE metadata endpoints.

Fixes: RSDK-526

See: googleapis/google-cloud-go#5430

@AdamMagaluk AdamMagaluk marked this pull request as ready for review August 9, 2022 18:10
@@ -16,10 +16,11 @@ on:

jobs:
test:
uses: viamrobotics/rdk/.github/workflows/test.yml@main
uses: viamrobotics/rdk/.github/workflows/test.yml@support-credentials
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently contains the test code pointing test.yaml to this branch. Once tests pass on the first run i'll update PR to remove that.

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's get rid of the extra move steps

.github/workflows/test.yml Outdated Show resolved Hide resolved
@viambot
Copy link
Member

viambot commented Aug 9, 2022

Code Coverage

Package Line Rate Health
go.viam.com/rdk/component/arm 52%
go.viam.com/rdk/component/arm/universalrobots 12%
go.viam.com/rdk/component/arm/varm 7%
go.viam.com/rdk/component/arm/xarm 2%
go.viam.com/rdk/component/arm/yahboom 7%
go.viam.com/rdk/component/base 67%
go.viam.com/rdk/component/base/agilex 62%
go.viam.com/rdk/component/base/boat 41%
go.viam.com/rdk/component/base/wheeled 75%
go.viam.com/rdk/component/board 64%
go.viam.com/rdk/component/board/arduino 9%
go.viam.com/rdk/component/board/fake 35%
go.viam.com/rdk/component/board/numato 17%
go.viam.com/rdk/component/board/pi 50%
go.viam.com/rdk/component/camera 73%
go.viam.com/rdk/component/camera/ffmpeg 71%
go.viam.com/rdk/component/camera/imagesource 56%
go.viam.com/rdk/component/camera/imagetransform 38%
go.viam.com/rdk/component/gantry 68%
go.viam.com/rdk/component/gantry/multiaxis 84%
go.viam.com/rdk/component/gantry/oneaxis 86%
go.viam.com/rdk/component/generic 85%
go.viam.com/rdk/component/gps 79%
go.viam.com/rdk/component/gps/nmea 44%
go.viam.com/rdk/component/gps/rtk 46%
go.viam.com/rdk/component/gripper 82%
go.viam.com/rdk/component/imu 69%
go.viam.com/rdk/component/input 86%
go.viam.com/rdk/component/input/gpio 87%
go.viam.com/rdk/component/motor 88%
go.viam.com/rdk/component/motor/dmc4000 69%
go.viam.com/rdk/component/motor/fake 67%
go.viam.com/rdk/component/motor/gpio 63%
go.viam.com/rdk/component/motor/gpiostepper 55%
go.viam.com/rdk/component/motor/tmcstepper 65%
go.viam.com/rdk/component/posetracker 89%
go.viam.com/rdk/component/sensor 89%
go.viam.com/rdk/component/sensor/ultrasonic 33%
go.viam.com/rdk/component/servo 86%
go.viam.com/rdk/config 82%
go.viam.com/rdk/control 57%
go.viam.com/rdk/data 79%
go.viam.com/rdk/grpc/client 78%
go.viam.com/rdk/grpc/server 57%
go.viam.com/rdk/ml 67%
go.viam.com/rdk/ml/inference 70%
go.viam.com/rdk/motionplan 79%
go.viam.com/rdk/operation 93%
go.viam.com/rdk/pointcloud 70%
go.viam.com/rdk/protoutils 80%
go.viam.com/rdk/referenceframe 78%
go.viam.com/rdk/registry 68%
go.viam.com/rdk/resource 90%
go.viam.com/rdk/rimage 78%
go.viam.com/rdk/rimage/calibrate 73%
go.viam.com/rdk/rimage/transform 74%
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67%
go.viam.com/rdk/robot 100%
go.viam.com/rdk/robot/framesystem 75%
go.viam.com/rdk/robot/impl 78%
go.viam.com/rdk/robot/web 62%
go.viam.com/rdk/robot/web/stream 86%
go.viam.com/rdk/samples/chess 0%
go.viam.com/rdk/samples/minirover 20%
go.viam.com/rdk/samples/obstacleAvoidance 0%
go.viam.com/rdk/services/baseremotecontrol 75%
go.viam.com/rdk/services/datamanager 84%
go.viam.com/rdk/services/datamanager/datasync 78%
go.viam.com/rdk/services/motion 88%
go.viam.com/rdk/services/navigation 36%
go.viam.com/rdk/services/sensors 87%
go.viam.com/rdk/services/shell 10%
go.viam.com/rdk/services/slam 71%
go.viam.com/rdk/services/vision 88%
go.viam.com/rdk/spatialmath 84%
go.viam.com/rdk/subtype 89%
go.viam.com/rdk/utils 75%
go.viam.com/rdk/vision 25%
go.viam.com/rdk/vision/chess 80%
go.viam.com/rdk/vision/delaunay 87%
go.viam.com/rdk/vision/keypoints 90%
go.viam.com/rdk/vision/objectdetection 81%
go.viam.com/rdk/vision/odometry 86%
go.viam.com/rdk/vision/odometry/cmd 27%
go.viam.com/rdk/vision/segmentation 49%
Summary 67% (17525 / 26223)

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooo

To avoid an issue with google go sdk leaking goroutines
we need to ensure it has a proper credential file which avoids
it looking up metadata from the GCE metadata endpoints.

See: googleapis/google-cloud-go#5430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants