This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
[READY] Add shutdown handler #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vheon You seem to be busy so I'll go ahead and merge this PR and #40. @zzbot r+ Reviewed 7 of 7 files at r1, 1 of 1 files at r2, 2 of 2 files at r3. Comments from Reviewable |
|
📌 Commit 430fe64 has been approved by |
zzbot
added a commit
that referenced
this pull request
Oct 9, 2017
[READY] Add shutdown handler Adding a `shutdown` endpoint makes it possible to cleanly exit JediHTTP on Windows. This is implemented the same way as in ycmd. See PR ycm-core/ycmd#282 for more detail. I made the following changes to the setup and teardown methods of the end-to-end tests: - start the server with logging level set to `debug`; - wait for the server to be ready before each test; - use the new `shutdown` handler to stop the server after each test; - write the output of the server to nosetests stdout at the end of each test. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/vheon/jedihttp/39) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/ycmd
that referenced
this pull request
Oct 18, 2017
[READY] Update JediHTTP Include [Jedi 0.11.0](https://github.com/davidhalter/jedi/blob/master/CHANGELOG.rst#0110-2017-09-20). Update descriptions in `GoToReferences` test. Use the new shutdown handler introduced in PR vheon/JediHTTP#39 to stop JediHTTP. Catch exception from shutdown request in semantic completers (when appropriate) so that cleaning up is done even if the request failed. Fix `TypeError` exception trying to remove the `None` logfile when stopping the server with the `StopServer` subcommand then restarting it with `RestartServer`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/856) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
shutdownendpoint makes it possible to cleanly exit JediHTTP on Windows. This is implemented the same way as in ycmd. See PR ycm-core/ycmd#282 for more detail.I made the following changes to the setup and teardown methods of the end-to-end tests:
debug;shutdownhandler to stop the server after each test;This change is