Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morgue tray adjacency fixes #36497

Open
wants to merge 8 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented May 13, 2024

[bugfix][oversight][sanity]

What this does

Closes #34551.
Closes #35645.
compresses the crematorium and its tray down to a subtype of the morgue stuff for less copied code and so the fix works with both.

How it was tested

putting stuff in and out of morgues and crematoriums, cremating the insides, using a subspace tunneller on the trays and cremators.

Changelog

🆑

  • bugfix: Morgue and crematorium trays can no longer be closed to teleport their contents back to the morgue or crematorium if not adjacent.
  • bugfix: Morgues and crematoriums no longer take the crystal and matter bin from the subspace tunneller its tray was in.

@D3athrow-Issues D3athrow-Issues added Bug / Fix This is either a bug or a fix for a bug. Oversight Unintended consequence. Sanity / Ghosthands Mobs are doing things they shouldn't be able to, oh no! Spooky. labels May 13, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review May 13, 2024 18:03
@SECBATON-GRIFFON SECBATON-GRIFFON changed the title Morgue tray movement fixes Morgue tray adjacency fixes May 13, 2024
@GreatBigFailure
Copy link
Contributor

Alternative solution: You close this and we all just act like it was merged so fun survives.
Have you ever put down a jaunter wormhole with 10 tracking beacons on you, shouted "scramble!" and spam clicked a morgue tray, thus randomizing the entire 6x6 area around yourself?
Have you tracking implanted a clown, given him a camera bug, and morgue trayed him away from any and all danger, ruining everyone else's day?
Consider what we stand to lose here! Don't take my baby away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug. Oversight Unintended consequence. Sanity / Ghosthands Mobs are doing things they shouldn't be able to, oh no! Spooky.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tunneler + morgue tray dupes and breaks reality EZ centcomm trip method
3 participants