Braindamage speech proc change. #36490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eneocho
added
Content
Eneocho
added
the
100% tested
|
I don't think running every brain damage message through at least 50 replacetexts is a good execution |
I'll look into how to improve it, I have an idea based on catbeast code. I'm way out of my field here so it might take a while. |
|
I think this is extra annoying from a gameplay perspective, but from a coding perspective please use some associative lists. |
west3436
requested changes
May 16, 2024
Comment on lines
+379
to
+409
| message = replacetext(message, "stop", "sotp") | ||
| message = replacetext(message, "retarded", "rarted") | ||
| message = replacetext(message, "george", "[pick("joerge", "george", "gorge", "gdoruge")]") | ||
| message = replacetext(message, "melon", "[pick("mellens", "melons", "mwrlins")]") | ||
| message = replacetext(message, "oxygen", "oxigen") | ||
| message = replacetext(message, "evolve", "evoluate") | ||
| message = replacetext(message, "unrealistic", "unralistic") | ||
| message = replacetext(message, "round", "rouns") | ||
| message = replacetext(message, "roles", "rolls") | ||
| message = replacetext(message, "worst", "wurst") | ||
| message = replacetext(message, "worse", "wurse") | ||
| message = replacetext(message, "vegan", "vegana") | ||
| message = replacetext(message, "boob", "bobs") | ||
| message = replacetext(message, "grief", "griff") | ||
| message = replacetext(message, "space", "spess") | ||
| message = replacetext(message, "carp", "crap") | ||
| message = replacetext(message, "reason", "raisin") | ||
| if(prob(50)) | ||
| message = replacetext(message, "engineer", "engiener") | ||
| message = replacetext(message, "pinpointer", "pin pointner") | ||
| message = replacetext(message, "singularity", "scrungulartiy") | ||
| message = replacetext(message, "based", "BASTE") | ||
| message = replacetext(message, "hos", "HITLER") | ||
| message = replacetext(message, "like", "liek") | ||
| message = replacetext(message, "damage", "damag") | ||
| message = replacetext(message, "millenial", "milenian") | ||
| message = replacetext(message, "telekinesis", "telikesis") | ||
| message = replacetext(message, "hulk", "halk") | ||
| message = replacetext(message, "epilepsy", "eppilapse") | ||
| message = replacetext(message, "shotgun", "shotgum it duntt mis") | ||
| message = replacetext(message, "suspicious", "sus") | ||
| message = replacetext(message, "among us", "amogus") |
There was a problem hiding this comment.
My brother in Christ; please use an associative list here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Changes the braindamage speech proc so it replaces a lot more words than before with their braindamaged counterpart. Also makes it so a lot of the words used in the forced braindamage lines are also spelled that way if said normally. Ex: Singularity becomes Scrungularity when spoken regularly because the forced braindamage line says scrungularity, and this is consistent with it.
It will also make it so 70% of the time, words that have two identical letters together like "look, wood, sleep, etc" lose one of those letters, becoming "lok, wod, slep, etc" (that's what the regex check is for). This is a sentence-wide check, so if one word gets the double letters removed, then all of them get them removed. There's also an independent 40% chance to replace any one word in a sentence with "um" or a variant.
Finally, it reduces the forced screaming and forced stutter chance a bit, since this felt better with those reduced odds.
This is by no means a comprehensive list. Please suggest more syllable swaps to add (general "he" -> "eh" rules rather than specific words) if you happen to think of one, or point at ones that should be removed if you think one they're too on the nose or don't fit.
Why it's good
Expands the braindamage speech a bunch, making braindamage speech have an effect on more than just some very specific words.
Tested pretty thoroughly and nothing seemed to break, so tested I guess.
馃啈