Brute Damage Causing Burns Bugfix

[jwhitak]

What this does

Fixes... uhh he never made the bug report. This PR fixes a rare albeit hilarious bug where sometimes when taking brute damage, you would actually take burn damage somehow. This was caused by the code that expands existing wounds not checking for the appropriate damage type.

Example: Remember that door you failed to hack roundstart? That burn wound on your hand, despite being cured like 30 minutes ago, has remained on you in the form of a grizzly burn scar with 0 damage! Later, when someone hits you in that same hand with a 10 melee damage shotgun, the damage initially attempts to expand an existing wound before creating its own. Hey, look, it's an old burn damage burn scar! Riiiip, 10 burn damage.

Why it's good

Because it removes a funny bug, it's not. But I guess consistency is good. If you get hit with brute damage, you expect to take brute damage.

How it was tested

me realizing how terrible our wound code is

(Tested via attacking self with various medical tools and lighters while using VV alongside debug messages to confirm status of wounds inflicted)

Changelog

🆑

• bugfix: Brute damage no longer causes or worsens burn wounds.

[SonixApache]

Hey just to check, could you have healed away that burn scar with a proper application of ointment and a bandage to avoid this damage?

[Eneocho]

Now add toxin "wounds" from being injected with toxins or stung by bees so we can replicate this bug in the future but with toxins.

[jwhitak]

Hey just to check, could you have healed away that burn scar with a proper application of ointment and a bandage to avoid this damage?

I'd have to double check but fully healed wounds, even treated, last for ten minutes after being fully healed.

[ErrorsWindows]

Now add toxin "wounds" from being injected with toxins or stung by bees so we can replicate this bug in the future but with toxins.

well this could work with something like the notably unused shotgun darts

[githubuser4141]

Sad, this should remain but be uncounted in terms of actual lethal damage. It should just persist to cause pain damage or count as damage that goes towards whenever the limb becomes nonfunctional, or something. It's one of those funny bugs that make people swear ICly and OOCly which is fun to watch.

[hacker-on-steroids]

i think i encountered this once, when shot by shotgun slugs i took a bit of burn damage instead of an IB and a shattered ribcage
thought it had something to do with armor but i guess you figured it out

where are the "i ded" / "my target's issue" labels?

[Eneocho]

where are the "i ded" / "my target's issue" labels?

Removed by kurf back when he was "cleaning up the labels". There's not a day I don't miss the funny labels.