-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
More TK and dropping sanity fixes #36475
Open
SECBATON-GRIFFON
wants to merge
36
commits into
vgstation-coders:Bleeding-Edge
Choose a base branch
from
SECBATON-GRIFFON:tk-sanity-fix-2
base: Bleeding-Edge
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
More TK and dropping sanity fixes #36475
SECBATON-GRIFFON
wants to merge
36
commits into
vgstation-coders:Bleeding-Edge
from
SECBATON-GRIFFON:tk-sanity-fix-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitak
reviewed
May 6, 2024
jwhitak
reviewed
May 6, 2024
SECBATON-GRIFFON
changed the title
More TK sanity fixes
More TK and dropping sanity fixes
May 6, 2024
Why does this change 80 files |
lot of it cuts down redundant code with the drop_item proc and failure messages, moved into the proc itself with support for a custom message and a default, most of the cut lines were the same so it was reused as the default, the rest were made custom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bugfix][consistency]
What this does
gets some ones i missed, changes the line back to before #36469 but with an alternate loc check (turns out adjacent is only one-directional, hence the issues it caused)
extends create_in_hands to support forcemoved items, messages and sounds (i notice this proc does actually fix the issue)
cuts down a ton of copypasted "you can't drop x" messages on item drop checks by putting it into the drop_item proc, with a flag to show it where necessary
Closes #36470.
Changelog
馃啈