Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

More TK and dropping sanity fixes #36475

Open
wants to merge 36 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented May 5, 2024

[bugfix][consistency]

What this does

gets some ones i missed, changes the line back to before #36469 but with an alternate loc check (turns out adjacent is only one-directional, hence the issues it caused)
extends create_in_hands to support forcemoved items, messages and sounds (i notice this proc does actually fix the issue)
cuts down a ton of copypasted "you can't drop x" messages on item drop checks by putting it into the drop_item proc, with a flag to show it where necessary
Closes #36470.

Changelog

馃啈

  • bugfix: Putting in hand adjacency now checks when inside things too again.
  • bugfix: Wired rods, cattle prods and spears no longer teleport into user's hands on telekinesis when made anymore.
  • bugfix: Items stuck to one's hand can no longer be removed by creating an item with it in many cases.
  • bugfix: Superglue-laden items can no longer have the glue removed by creating an item on them in many cases.

@D3athrow-Issues D3athrow-Issues added the Bug / Fix This is either a bug or a fix for a bug. label May 5, 2024
code/game/atoms.dm Outdated Show resolved Hide resolved
@SECBATON-GRIFFON SECBATON-GRIFFON changed the title More TK sanity fixes More TK and dropping sanity fixes May 6, 2024
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review May 9, 2024 13:34
@kilozombie
Copy link
Contributor

Why does this change 80 files

@SECBATON-GRIFFON
Copy link
Contributor Author

Why does this change 80 files

lot of it cuts down redundant code with the drop_item proc and failure messages, moved into the proc itself with support for a custom message and a default, most of the cut lines were the same so it was reused as the default, the rest were made custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telekinesis-built Items Teleport to Your Hands
4 participants