-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryo tube gib and output fixes #36374
base: Bleeding-Edge
Are you sure you want to change the base?
Cryo tube gib and output fixes #36374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I finally got around to properly reviewing this since it's more of a feature addition than a bugfix (probation.jpg).
My initial thoughts are that when gibbing something inside of the cryo tube, the stuff still goes flying outside the tube.
I thought this right leg was outside the tube as well somehow... well, turns out, it wasn't outside the tube, though it appeared to be due to the strange displacement. It also wasn't moving using the submerged system, so it looked like it was on the back wall somehow. Probably just submerge_anim not being called on them. Note that it's normal for these objects to show up on the right click menu.
Blowing up another person in cryo shows off more of the oddities. This gibbing stuff is pretty much not that great.
I'm also concerned about the odd way submerging is handled regarding entering a submerging loc, since you still have to manually call the submerging animation proc to even start the process. It's yet another variable added to every single atom in the game where it's only used in cryo, so this can probably be implemented in a better way.
stopped the limbs and gibs from being ejected from the tube. |
[consistency][oversight][bugfix]
What this does
Closes #35533.
Closes #29422.
Closes #16951.
also makes the results from the gib show up and float in the cryomix and allows them to be retrieved in ejection. note that dropping from mobs is still the only way they can show up inside a cryotube at all.
creates code for the floating animation to be reused inside any atom with "submerging" set to 1, currently still only applies for cryotubes.
makes the mob a vis_contents inside of it to properly show the gib animation and etc.
Why it's good
stops these items (or slime puddles) from being lost.
Changelog
馃啈