Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryo tube gib and output fixes #36374

Open
wants to merge 37 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Apr 16, 2024

[consistency][oversight][bugfix]

What this does

Closes #35533.
Closes #29422.
Closes #16951.
image
also makes the results from the gib show up and float in the cryomix and allows them to be retrieved in ejection. note that dropping from mobs is still the only way they can show up inside a cryotube at all.
creates code for the floating animation to be reused inside any atom with "submerging" set to 1, currently still only applies for cryotubes.
makes the mob a vis_contents inside of it to properly show the gib animation and etc.

Why it's good

stops these items (or slime puddles) from being lost.

Changelog

馃啈

  • bugfix: Contents from a gibbed mob now show up nicer in cryo tube examining.
  • bugfix: Cryo tubes now output at multitool direction as normal.
  • tweak: Cryo tubes now use more comprehensive output checks for their exit, taking turf and object density into account.
  • tweak: Dropped limbs no longer spread away from a mob in cryo.
  • tweak: Gibs no longer spawn for gibbed mobs in cryo, only showing up on ejection.
  • tweak: Dropped items from gibbing now show up in cryo tubes and can be retrieved.
  • bugfix: As a result, this also includes slime puddles.

@D3athrow-Issues D3athrow-Issues added Bug / Fix This is either a bug or a fix for a bug. Consistency Issue This thing in question isn't consistent across multiple things. Oversight Unintended consequence. labels Apr 16, 2024
code/game/atoms.dm Outdated Show resolved Hide resolved
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft April 17, 2024 01:48
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review April 17, 2024 02:03
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft April 17, 2024 02:24
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review April 17, 2024 02:56
@SECBATON-GRIFFON SECBATON-GRIFFON changed the title Cryo tube gib sanity Cryo tube gib and output fixes Apr 17, 2024
SECBATON-GRIFFON added 2 commits April 17, 2024 04:37
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft April 17, 2024 04:08
@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review April 17, 2024 15:13
Copy link
Collaborator

@jwhitak jwhitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I finally got around to properly reviewing this since it's more of a feature addition than a bugfix (probation.jpg).

My initial thoughts are that when gibbing something inside of the cryo tube, the stuff still goes flying outside the tube.

image
image

I thought this right leg was outside the tube as well somehow... well, turns out, it wasn't outside the tube, though it appeared to be due to the strange displacement. It also wasn't moving using the submerged system, so it looked like it was on the back wall somehow. Probably just submerge_anim not being called on them. Note that it's normal for these objects to show up on the right click menu.

image

Blowing up another person in cryo shows off more of the oddities. This gibbing stuff is pretty much not that great.

I'm also concerned about the odd way submerging is handled regarding entering a submerging loc, since you still have to manually call the submerging animation proc to even start the process. It's yet another variable added to every single atom in the game where it's only used in cryo, so this can probably be implemented in a better way.

code/datums/locking_category.dm Outdated Show resolved Hide resolved
code/game/atoms.dm Outdated Show resolved Hide resolved
@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented May 20, 2024

Blowing up another person in cryo shows off more of the oddities. This gibbing stuff is pretty much not that great.

stopped the limbs and gibs from being ejected from the tube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix This is either a bug or a fix for a bug. Consistency Issue This thing in question isn't consistent across multiple things. Oversight Unintended consequence.
Projects
None yet
4 participants