Changes bicon() to use the builtin 515 feature #33764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we are on 515, should this be merged or cleaned up? |
|
It would require us to require 515 clients, and there seem to be some issues with 515 clientside. I'm told it has crashing issues (though haven't seen it myself) and also the admin Special panel just doesn't seem to show up at all. The other skin issues seem to be fixed, though. |
|
Is this any closer to being mergeable? |
|
apparently so, the chicken has decreed 515 switch will be mandatory soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously DNM until we're on 515.
515 makes this Just Work. It's clientside and even includes overlays (though not
vis_contents, which may or may not be a bug). Includes a couple hacks to ensure it works in edge cases. We could finally add examine icons back to humans with this. They never actually worked properly before, but they do with this.I should probably also excise all other uses of
icon2base64()as well but I haven't yetJust opening because I want to remember it and also clean up my local copy