Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace JSX with Thoas for Json #2115

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

codeadict
Copy link
Contributor

Proposed Changes

Please describe the big picture of your changes here to communicate to the
VerneMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@ioolkos
Copy link
Contributor

ioolkos commented Mar 14, 2023

oh yay! :)

@ioolkos
Copy link
Contributor

ioolkos commented May 8, 2023

@codeadict do you consider this mergeable or WIP? (apologies for not being here earlier, was thinking the PR is a draft)

@codeadict
Copy link
Contributor Author

@ioolkos its not mergeable yet. I have to fix lots of Lua tests still

@ioolkos
Copy link
Contributor

ioolkos commented May 9, 2023

@codeadict ah yes, I missed that, thanks!

@mths1
Copy link
Contributor

mths1 commented Feb 11, 2024

@ioolkos , @codeadict: I worked a little bit on this one and "made it work" for Lua. See https://github.com/mths1/vernemq/tree/json_thoas (and then vmq_diversity_json.erl)

  • I was not able to get lua working with iolists, so I reverted to binary
  • There was a small issue in

json_to_lua(?JSON_EMPTY_OBJECT) ->
?LUA_EMPTY_TABLE;

which was driving me nuts as #{} for whatever reason matches also an non empty maps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants