Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL salted hash_method support #1141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Androbin
Copy link

@Androbin Androbin commented Apr 11, 2019

The PostgreSQL backend uses salt by default.
This PR makes the MySQL backend use salt as well.

If the lack of customization bothers you just as much as me, maybe take a look at #1142 instead.

@larshesel
Copy link
Contributor

Hi, thanks for the two pull requests. I'm afraid we can't just change the way it works like this as this would break things for existing users. Do you see a way to make this backwards compatible?

@Androbin
Copy link
Author

Androbin commented Apr 11, 2019

@larshesel

  • The enum now has separate _salt versions instead.
  • The string now matches the existing values separately.

@Androbin Androbin changed the title Make MySQL hash_method use salt Add MySQL salted hash_method support Nov 1, 2019
@ioolkos
Copy link
Contributor

ioolkos commented Aug 5, 2020

This PR got obviously forgotten somehow. I'll take care & decide what to do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants