Architecture Seg Fault Issue #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saaramahmoudi
changed the title
github-actions
bot
added
libarchfpga
vaughnbetz
reviewed
May 14, 2024
libs/libarchfpga/src/echo_arch.cpp
Outdated
| @@ -232,9 +232,13 @@ void PrintArchInfo(FILE* Echo, const t_arch* arch) { | |||
| } | |||
|
|
|||
| fprintf(Echo, "\tInput Connect Block Switch Name Within a Same Die: %s\n", arch->ipin_cblock_switch_name[0].c_str()); | |||
There was a problem hiding this comment.
I think it's worth commenting the [0] and [1] indices: [0] is the ipin_cblock_switch_name for within die and [1] is between dice? This might be more clear with constexpr that gives names to 0 and 1 for the lookups.
There was a problem hiding this comment.
@vaughnbetz fixed it
|
Changes look good but CI failed hard….VaughnOn May 14, 2024, at 5:12 PM, sara_mahmoudi ***@***.***> wrote:
@saaramahmoudi commented on this pull request.
In libs/libarchfpga/src/echo_arch.cpp:
@@ -232,9 +232,13 @@ void PrintArchInfo(FILE* Echo, const t_arch* arch) {
}
fprintf(Echo, "\tInput Connect Block Switch Name Within a Same Die: %s\n", arch->ipin_cblock_switch_name[0].c_str());
@vaughnbetz fixed it
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@vaughnbetz Sorry about that, I accidentally had an extra [, which causes compile issue. Fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current codebase, when we activate --echo_file, we might get a segmentation file while writing the architecture file. The reason is that we look at the number of layouts instead of layers. The architecture might have different layouts but still not be 3D using multiple <fixed_layout> options.
This PR addresses the following issue:
Segmentation Fault
Types of changes
@vaughnbetz