Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the maximum pres_fac #2523

Merged
merged 22 commits into from
May 30, 2024
Merged

Set the maximum pres_fac #2523

merged 22 commits into from
May 30, 2024

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Apr 2, 2024

This pull request introduces a new command line argument to set the maximum pres_fac, which is now defaulted to 1000.

The pres_fac coefficient is used to adjust the cost of an overused net by multiplying it with the number of nets overusing it. This adjustment encourages the router to explore alternative routes. Previously, the maximum value for this coefficient was set to an extremely large number, resulting in strange router behavior such as excessive ripping up connections toward the end of routing. To address this issue, the default maximum value is now set to 1000, providing more predictable router behavior. Additionally, users have the flexibility to adjust this value as needed via the command line.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions docs Documentation lang-cpp C/C++ code labels Apr 2, 2024
@vaughnbetz
Copy link
Contributor

QoR data?
The one CI failure is a small circuit (alu4) that has a higher critical path delay. Not a real concern so OK.

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change again.

doc/src/vpr/command_line_usage.rst Outdated Show resolved Hide resolved
vpr/src/route/route.cpp Outdated Show resolved Hide resolved
@vaughnbetz
Copy link
Contributor

@amin1377 : please merge once CI passes.

@vaughnbetz
Copy link
Contributor

Thanks Amin. The code all looks good. Just for safety, can you run a VTR minimum channel width regtest to confirm QoR (min chan width, routing time, etc.) look OK for it?

@amin1377
Copy link
Contributor Author

image

@vaughnbetz
Copy link
Contributor

Looks good, thanks. I'll merge as soon as CI is green.

@vaughnbetz vaughnbetz merged commit efe7cc0 into master May 30, 2024
100 of 102 checks passed
@vaughnbetz vaughnbetz deleted the pres_fac_max branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants