Bug fix: asymmetric grid with bidirectional routing #2514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace grid.width() check with grid.height() for top perimeter channels
Description
For FPGA fabrics with non-square grids and bidirectional routing the check to determine if you were on a perimeter tile was incorrect. The check compared the (x,y) location against the grid.width() for both dimensions. The vertical dimension should be compared against the grid.height().
Related Issue
Motivation and Context
Before this change, asymmetric grid dimensions with bidirectional routing would result in a "node_index" assertion error and a "core dump" which aborted vpr execution while creating the routing resource graph. This change will now allow you to run vpr on non-square grids with bidirectional routing.
How Has This Been Tested?
All regression tests were rerun and passed locally. A simple example with an asymmetric grid and bidirectional routing that previously resulted in a core dump and node_index assertion error was also run through the vpr flow successfully on my local machine.
Types of changes
Checklist: