Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D SIV Delay & Median Move #2490

Merged
merged 27 commits into from
May 30, 2024
Merged

Fix 3D SIV Delay & Median Move #2490

merged 27 commits into from
May 30, 2024

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Feb 19, 2024 •
edited

  • Add the scaled delay from the "koios_3d" benchmark into the 3D SIV-like architecture. The inter-die delay is calculated by multiplying the delay of the L4 segment by the ratio of the inter-die delay to the L4 delay of the Koios_3D architecture.
  • Fix median/weighted median move to get the median layer of bounding boxes instead of pins (as it is the case for choosing x and y locations)

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Feb 20, 2024
@amin1377 amin1377 changed the title Fix Inter-Die Connection Delay on SIV-Like Architecture Fix 3D SIV Delay & Median Move Mar 4, 2024
@amin1377
Copy link
Contributor Author

amin1377 commented Mar 4, 2024

2D Titan:
Screenshot from 2024-03-04 16-08-26

@vaughnbetz
Copy link
Contributor

Add 3D results.

vaughnbetz
vaughnbetz requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes suggested, and please get the 3D data.

vpr/src/place/centroid_move_generator.cpp Show resolved Hide resolved
vpr/src/place/median_move_generator.cpp Show resolved Hide resolved
vpr/src/place/place.cpp Outdated Show resolved Hide resolved
vpr/src/place/placer_context.h Show resolved Hide resolved
vtr_flow/arch/multi_die/stratixiv_3d/3d_full_OPIN_inter_die_stratixiv_arch.timing.xml Show resolved Hide resolved
@vaughnbetz
Copy link
Contributor

@amin1377 : is this one ready to merge?

@amin1377
Copy link
Contributor Author

@vaughnbetz: I've just added more comments and rebased it with the master branch. Once the CI tests pass successfully, it'll be ready for merging.

@vaughnbetz
Copy link
Contributor

Please merge once CI passes and the conflicts are resolved.

@amin1377 amin1377 merged commit 486be09 into master May 30, 2024
101 of 102 checks passed
@amin1377 amin1377 deleted the fix_3d_delay branch May 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz requested changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amin1377 @vaughnbetz