Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace assert with non-fatal check for mode conflict #2433

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KA7E
Copy link
Contributor

@KA7E KA7E commented Nov 8, 2023

Replace assert with non-fatal check for mode conflict. Conflict returns BLK_FAILED_FEASIBLE.

Description

Changed an assertion to an if statement.

Related Issue

Motivation and Context

The legalizer encounters mode conflicts, since the external placer does not model modes and may not differentiate between .names and lcell luts. The legalizer needs to be able to continue when it encounters a mode mismatch.

How Has This Been Tested?

CI tests pass (except known spurious Clang failures)
Code with this change has successfully run place and route on all Titan23s.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Nov 9, 2023
@vaughnbetz
Copy link
Contributor

Updating branch with master changes & re-launching CI. Clang errors should be gone now.
If you know what the error condition is you could write a comment; if you're not sure what the comment should be we can leave it (or if it is obvious so no comment needed).

@github-actions github-actions bot added the lang-cpp C/C++ code label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants