Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix koios tests #2419

Conversation

MohamedElgammal
Copy link
Contributor

…s and rename the others to koios_medium or koios_large

Description

Some of Koios bencchmarks are failing in CI due to issue #2036. Hence, I am splitting them in seperate tests with larger devices. For the other tests, I am renaming them to koios_large and koios_medium

Types of changes

  • Bug fix (change which fixes an issue)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@poname poname mentioned this pull request Dec 20, 2023
7 tasks
@vaughnbetz
Copy link
Contributor

@MohamedElgammal : this PR looks like it has been overtaken by other PRs. Should I close it?

@MohamedElgammal
Copy link
Contributor Author

@vaughnbetz you are correct. This PR was overtaken by others. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants