Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for npm audit fix #689 #704

Merged
merged 2 commits into from May 23, 2018
Merged

feat: support for npm audit fix #689 #704

merged 2 commits into from May 23, 2018

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented May 21, 2018 •
edited

Type: feature

Description:

This PR allow a built-in usage of npm audit command via verdaccio.

Installation

npm install --global verdaccio@beta    
npm install --global verdaccio-audit

Usage

To enable it you need to add this to your configuration file.

middlewares:
  audit:
    enabled: true

Run

➜ verdaccio
 warn --- config file  - /Users/user/.config/verdaccio/config.yaml
 warn --- Plugin successfully loaded: htpasswd
 warn --- Plugin successfully loaded: audit

Note: It's gonna be built-in in next beta but disabled by default.

Resolves #689

Project: https://github.com/verdaccio/verdaccio-audit

track clients issues here:

@juanpicado juanpicado self-assigned this May 21, 2018
@juanpicado juanpicado added this to the 3.0.0 milestone May 21, 2018
@juanpicado juanpicado added this to To do in Roadmap via automation May 21, 2018
@juanpicado
feat: support for npm audit fix #689
f9f180d 
it is dissabled and commented out by default
@juanpicado juanpicado mentioned this pull request May 21, 2018
Closed
apexskier
apexskier reviewed May 21, 2018
View reviewed changes
conf/default.yaml Outdated
@@ -43,6 +43,11 @@ packages:
# if package is not available locally, proxy requests to 'npmjs' registry
proxy: npmjs

# To use `npm audit` comment out the following section
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "comment out" be replaced with "uncomment"?

@juanpicado juanpicado merged commit ac5f99c into master May 23, 2018
Roadmap automation moved this from To do to Done May 23, 2018
@juanpicado juanpicado deleted the feature-audit branch May 23, 2018 04:50
@lock
Copy link

lock bot commented Nov 19, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apexskier apexskier apexskier left review comments

@ayusharma ayusharma Awaiting requested review from ayusharma

@AvailCat AvailCat Awaiting requested review from AvailCat

Assignees

@juanpicado juanpicado

Labels
topic: feature request
Projects
No open projects
Roadmap
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juanpicado @apexskier