Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Update test fixture version #11514

Merged
merged 5 commits into from Apr 30, 2024
Merged

[next] Update test fixture version #11514

merged 5 commits into from Apr 30, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 30, 2024

Noticed in #11503 that this test fixture is incorrectly locked to a specific version when we don't want it to be.

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 1a85b1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ijjk ijjk added the pr: automerge Automatically merge the PR when checks pass label Apr 30, 2024
@@ -0,0 +1,5 @@
---
'@vercel/next': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but this is probably doesn't require even a patch version bump

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we remove the label that tells the changeset to ignore test only changes? We tried on a previous PR and it was blocking merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't a thing I've ever heard of! I've always seen them required in my time here but running changeset with --empty will generate an empty one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just manually delete the content between the ---s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can push an empty changeset to make the bot happy, but anyways, the changeset is not a required check, so it's not a requirement.

@ijjk ijjk merged commit 3420ba0 into main Apr 30, 2024
110 checks passed
@ijjk ijjk deleted the ijjk/update-fixture-version branch April 30, 2024 20:03
TooTallNate pushed a commit that referenced this pull request Apr 30, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@34.1.7

### Patch Changes

- Updated dependencies
\[[`3420ba015`](3420ba0)]:
    -   @vercel/next@4.2.6

## @vercel/next@4.2.6

### Patch Changes

- [next] Update test fixture version
([#11514](#11514))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants