Migrate certs argument parsing #11493
Draft
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67fd7d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
commented
Apr 26, 2024
Comment on lines
+95
to
+96
| { name: 'overwrite', shorthand: null, type: Boolean, deprecated: false }, | ||
| { name: 'output', shorthand: null, type: String, deprecated: false }, |
There was a problem hiding this comment.
Do we want to add a description and show help text for these flags? We've been parsing them but not showing them in the help until now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates
vc certsto use updated argument parsing utilities.Fixes an incorrect shorthand flag for
vc certs --next->-N.I've also added
--overwriteand--outputto theCommandstruct. However, I defaulted to not showing any help text for these flags.