Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] fix domains access permission issues #11446

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smaeda-ks
Copy link
Member

Also related: https://github.com/vercel/api/pull/27464

After the Hobby plan migration, several CLI commands stopped working for migrated users due to domains access check.

The main issue is, after the migration, we basically kept all domain resources (Apex zones, the account-level domains) under a personal account and created a new Hobby team, where all other resources (e.g., projects) were moved over. So, those domains are technically under a different account than their new Hobby team, and hence, access/permission checks started failing.

To work around it, currently, users need to explicitly move domains from their personal account to their Hobby team, which is considered to be a breaking change in UX.

To maintain the backward compatibility of this workflow, this PR adds fallback logic to fetch domains from personal account.

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 6edf428

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant