Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-utils] Add zero config detection for bun package manager #10486

Merged
merged 7 commits into from Sep 11, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 11, 2023

Important

This PR will only support Bun as a package manager at build time.
Bun will not work at runtime with Serverless Functions or Edge Functions at this time.

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 89bb4a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@vercel/build-utils Minor
vercel Patch
@vercel/client Patch
@vercel/gatsby-plugin-vercel-builder Patch
@vercel/node Patch
@vercel/static-build Patch
@vercel-internals/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

trek
trek previously approved these changes Sep 11, 2023
@isaac-mcfadyen
Copy link

I saw that this was previously opened in #10244 and in fact was already closed with:

We don't currently plan to support bun as a package manager or a runtime

Just curious where things changed here to make support for Bun a wanted feature?

@EndangeredMassa
Copy link
Contributor

@isaac-mcfadyen yes, sorry for the confusion. At the time of your previous PR, we had not received many requests for bun support (even as just the package manager). As you can imagine, the release of 1.0.0 caused a lot of excitement in the growing community, which lead to an increase in requests.

} else if (bunLockBin) {
cliType = 'bun';
lockfilePath = bunLockPath;
// TODO: read "bun-lockfile-format-v0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not forget to make a linear ticket for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a ticket when Bun 2.0 comes out or if the lockfile changes (hopfully that would be semver major but you never know).

I asked here https://github.com/orgs/vercel/discussions/2021#discussioncomment-6968013

@styfle
Copy link
Member Author

styfle commented Sep 11, 2023

Just curious where things changed here to make support for Bun a wanted feature?

The feature request had maybe 50 upvotes yesterday.

Today it has 750+ upvotes, likely because of this tweet.

@styfle
Copy link
Member Author

styfle commented Sep 11, 2023

Hmm, there appears to be a bug with Bun.

I filed an issue here: oven-sh/bun#5007

@styfle styfle merged commit 45b73c7 into main Sep 11, 2023
106 checks passed
@styfle styfle deleted the styfle/zero-950-auto-detect-bun-lockfile branch September 11, 2023 21:26
styfle pushed a commit that referenced this pull request Sep 11, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/build-utils@7.2.0

### Minor Changes

- Add new optional prerender field: experimentalStreamingLambdaPath
([#10476](#10476))

- [build-utils] Add zero config detection for bun package manager
([#10486](#10486))

### Patch Changes

- add `experimentalBypassFor` field to Prerender
([#10481](#10481))

## vercel@32.2.1

### Patch Changes

- Update @vercel/fun@1.1.0
([#10477](#10477))

- [node] upgrade edge-runtime
([#10451](#10451))

- Updated dependencies
\[[`6784e7751`](6784e77),
[`a8ad17626`](a8ad176),
[`0ee089a50`](0ee089a),
[`f15cba614`](f15cba6),
[`b265e13d4`](b265e13),
[`50e04dd85`](50e04dd),
[`45b73c7e8`](45b73c7),
[`a732d30c8`](a732d30),
[`9d64312aa`](9d64312),
[`6baefc825`](6baefc8),
[`989f0d813`](989f0d8),
[`d8bc570f6`](d8bc570)]:
    -   @vercel/go@3.0.1
    -   @vercel/redwood@2.0.2
    -   @vercel/remix-builder@2.0.4
    -   @vercel/hydrogen@1.0.1
    -   @vercel/static-build@2.0.5
    -   @vercel/build-utils@7.2.0
    -   @vercel/next@4.0.3
    -   @vercel/node@3.0.5
    -   @vercel/python@4.0.1
    -   @vercel/ruby@2.0.2

## @vercel/client@13.0.3

### Patch Changes

- Updated dependencies
\[[`50e04dd85`](50e04dd),
[`45b73c7e8`](45b73c7),
[`d8bc570f6`](d8bc570)]:
    -   @vercel/build-utils@7.2.0

## @vercel/edge@1.0.2

### Patch Changes

- [node] upgrade edge-runtime
([#10451](#10451))

## @vercel/gatsby-plugin-vercel-builder@2.0.5

### Patch Changes

- Updated dependencies
\[[`50e04dd85`](50e04dd),
[`45b73c7e8`](45b73c7),
[`9d64312aa`](9d64312),
[`d8bc570f6`](d8bc570)]:
    -   @vercel/build-utils@7.2.0
    -   @vercel/node@3.0.5

## @vercel/go@3.0.1

### Patch Changes

- Update to esbuild script
([#10468](#10468))

## @vercel/hydrogen@1.0.1

### Patch Changes

- Use `build-builder.mjs` script to bundle, and remove types and source
maps ([#10480](#10480))

## @vercel/next@4.0.3

### Patch Changes

- fix content-type for RSC prefetches
([#10487](#10487))

## @vercel/node@3.0.5

### Patch Changes

- [node] upgrade edge-runtime
([#10451](#10451))

- Updated dependencies
\[[`50e04dd85`](50e04dd),
[`45b73c7e8`](45b73c7),
[`d8bc570f6`](d8bc570)]:
    -   @vercel/build-utils@7.2.0

## @vercel/python@4.0.1

### Patch Changes

- Update to esbuild script
([#10470](#10470))

## @vercel/redwood@2.0.2

### Patch Changes

- Update to esbuild script
([#10471](#10471))

## @vercel/remix-builder@2.0.4

### Patch Changes

- Use `build-builder.mjs` script to bundle, and remove types and source
maps ([#10479](#10479))

## @vercel/ruby@2.0.2

### Patch Changes

- Update to esbuild script
([#10472](#10472))

## @vercel/static-build@2.0.5

### Patch Changes

- Build package using "esbuild"
([#10462](#10462))

-   Updated dependencies \[]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.5

## @vercel-internals/types@1.0.10

### Patch Changes

- Updated dependencies
\[[`50e04dd85`](50e04dd),
[`45b73c7e8`](45b73c7),
[`d8bc570f6`](d8bc570)]:
    -   @vercel/build-utils@7.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants