feat(turbopack-ecmascript): use import attributes for annotations #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
Linux Benchmark for 22d3e14Click to view benchmark
|
sokra
approved these changes
Feb 29, 2024
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
243047d
to
da02f16
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
da02f16
to
bcb047d
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
bcb047d
to
968934c
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
968934c
to
61f64d2
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
61f64d2
to
98c813c
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
98c813c
to
edc69b8
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
edc69b8
to
96a1fee
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
96a1fee
to
e0a5a0a
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
b2bc908
to
56b6806
Compare
ForsakenHarmony
commented
May 15, 2024
| reference_type.into_value(), | ||
| ReferenceType::EcmaScriptModules(EcmaScriptModulesReferenceSubType::ImportWithType(_)) | ||
| ) { | ||
| options.extensions.clear(); |
There was a problem hiding this comment.
Is this correct for with { type: "json" }?
ForsakenHarmony
commented
May 15, 2024
| for (i, rule) in options.await?.rules.iter().enumerate() { | ||
| if has_type_attribute && current_module_type.is_some() { |
There was a problem hiding this comment.
Is this correct for with { type: "json" }?
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
56b6806
to
00134d6
Compare
ForsakenHarmony
force-pushed
the
hrmny/import-attribute-annotations
branch
from
00134d6
to
2921008
Compare
|
If the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No more magic string literal 🎉
This also enables
with { type: "json }Blocked by vercel/next.js#59494
Closes PACK-2119