Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix ci error and upgrade action version #2952

Merged
merged 8 commits into from May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/install/action.yml
Expand Up @@ -4,10 +4,10 @@ runs:
using: composite
steps:
- name: Setup pnpm
uses: pnpm/action-setup@v2.2.4
uses: pnpm/action-setup@v3

- name: Use Node.js 18
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
cache: pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-canary.yml
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/workflows/install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-legacy-react.yml
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/workflows/install
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/test-release.yml
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/workflows/install
Expand All @@ -23,6 +23,7 @@ jobs:
pnpm clean
pnpm build
pnpm run-all-checks
npm pack
pnpm attw
pnpm test
pnpm test:build
Expand All @@ -32,7 +33,7 @@ jobs:
image: mcr.microsoft.com/playwright:v1.34.3-focal
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/workflows/install
Expand All @@ -45,7 +46,7 @@ jobs:
pnpm test:e2e
- name: Upload test results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: playwright-report
path: playwright-report
Expand All @@ -57,7 +58,7 @@ jobs:
id-token: write
steps:
- name: Check out
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
uses: ./.github/workflows/install
Expand Down
33 changes: 3 additions & 30 deletions .github/workflows/trigger-release.yml
Expand Up @@ -17,10 +17,6 @@ on:
- minor
- major

secrets:
RELEASE_BOT_GITHUB_TOKEN:
required: true

name: Trigger Release

env:
Expand All @@ -34,36 +30,13 @@ jobs:

environment: release-${{ github.event.inputs.releaseType }}-${{ github.event.inputs.semverType }}
steps:
- name: Setup node
uses: actions/setup-node@v3
if: ${{ steps.docs-change.outputs.docsChange == 'nope' }}
with:
node-version: 18
check-latest: true

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 10
token: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }}

- run: npm i -g pnpm@${PNPM_VERSION}

- id: get-store-path
run: echo STORE_PATH=$(pnpm store path) >> $GITHUB_OUTPUT

- uses: actions/cache@v3
timeout-minutes: 5
id: cache-pnpm-store
with:
path: ${{ steps.get-store-path.outputs.STORE_PATH }}
key: pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
restore-keys: |
pnpm-store-
pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}

- run: pnpm install

- name: Install
uses: ./.github/workflows/install
- run: |
pnpm clean
pnpm build
Expand Down
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -100,7 +100,7 @@
"watch": "bunchee -w",
"build": "bunchee",
"build:e2e": "pnpm next build e2e/site",
"attw": "attw --pack",
"attw": "attw --pack .",
"types:check": "tsc --noEmit",
"prepublishOnly": "pnpm clean && pnpm build",
"publish-beta": "pnpm publish --tag beta",
Expand All @@ -121,7 +121,7 @@
]
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.7.0",
"@arethetypeswrong/cli": "^0.15.3",
"@playwright/test": "^1.34.3",
"@swc/core": "^1.3.62",
"@swc/jest": "0.2.26",
Expand Down