Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify ci config and bump some deps version #2770

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented Sep 5, 2023

No description provided.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 953a51b:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@socket-security
Copy link

socket-security bot commented Sep 5, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@arethetypeswrong/cli 0.11.0 filesystem, environment +0 24.7 kB andrewbranch
eslint-config-prettier 8.8.0...9.0.0 environment +2/-2 3.47 MB lydell
bunchee 3.6.0...3.6.1 None +0/-1 48.8 kB huozhi
eslint 8.42.0...8.50.0 None +1/-1 3.45 MB eslintbot
@playwright/test 1.34.3...1.38.1 None +1/-1 7.14 MB aslushnikov

🚮 Removed packages: lint-staged@13.2.2, next@13.4.4, prettier@2.8.8, react@18.2.0, react-dom@18.2.0

@@ -92,7 +92,7 @@
"build": "pnpm build-package _internal && pnpm build-package core && pnpm build-package infinite && pnpm build-package immutable && pnpm build-package mutation && pnpm build-package subscription",
"build:e2e": "pnpm next build e2e/site",
"build-package": "bunchee --cwd",
"attw": "attw --pack",
"attw": "attw --pack --ignore-rules cjs-only-exports-default",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to ignore this rule?

can we also run attw in the test:build process on ci so it's get covered on CI?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has already been included in CI.

We need to ignore this rule because SWR use default exports which could cause problems. https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/CJSOnlyExportsDefault.md#-cjs-default-export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants